fix: resolve security review findings#89
Merged
Conversation
release.yml: Move github.ref_name to env var to prevent script injection via crafted branch names (CodeQL alert #39) sec-opengrep.yml: Verify downloaded binary against GitHub API digest (sha256). Still fetches latest release but validates integrity before execution. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
1. Script injection in release.yml (CodeQL alert #39)
Moved
github.ref_namefrom direct expression interpolation inrun:block to anenv:variable. Prevents command injection via crafted branch names.2. Supply chain hardening for sec-opengrep.yml
Still fetches the latest opengrep release (no version pin), but now verifies the downloaded binary against the SHA256 digest from the GitHub Releases API before execution. If the checksum doesn't match, the workflow fails.
Both findings from the security review (AI + CodeQL cross-reference).